Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix start issues under standalone mode #2352

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Sep 11, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix start issues under standalone mode

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu marked this pull request as ready for review September 12, 2023 04:05
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (migrate-region-server@6957fd1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             migrate-region-server    #2352   +/-   ##
========================================================
  Coverage                         ?   77.39%           
========================================================
  Files                            ?      724           
  Lines                            ?   114877           
  Branches                         ?        0           
========================================================
  Hits                             ?    88913           
  Misses                           ?    25964           
  Partials                         ?        0           

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Sep 12, 2023
Merged via the queue into GreptimeTeam:migrate-region-server with commit 38ca7ca Sep 12, 2023
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* fix: fix standalone starts

* chore: bump raft-engine to 571462e

* refactor: remove MetadataService
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* fix: fix standalone starts

* chore: bump raft-engine to 571462e

* refactor: remove MetadataService
waynexia pushed a commit that referenced this pull request Sep 12, 2023
* fix: fix standalone starts

* chore: bump raft-engine to 571462e

* refactor: remove MetadataService
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request Sep 13, 2023
* fix: fix standalone starts

* chore: bump raft-engine to 571462e

* refactor: remove MetadataService
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: fix standalone starts

* chore: bump raft-engine to 571462e

* refactor: remove MetadataService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants